Move all icon and image definitions to theme file and make some consistency fixes.
In anticipation of a colorized version of the artist image, there are two definitions which currently hold the same icon.
Also enables the display of a default cover in context view.
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:c0890f4487a9: move all image and icon strings to theme file
no icon issues throughout the app
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Reading a little bit more about how platform specific files work, all those changes must be carried over to the windows theme file, otherwise the windows build will break. Correct?
Comment Actions
Yes, this is the idea. I should have used that when solving a contrast problem on windows without breaking dark theme on linux.
Comment Actions
Thanks for your work.
This should be much easier now to have a solution for having bundled icons when not having kdeclarative as a dependency.