Differential D9697

move all image and icon strings to theme file
ClosedPublic
Actions

Authored by astippich on Jan 6 2018, 9:33 AM.

Details

Reviewers

mgallien

Group Reviewers

Elisa

Commits

R255:c0890f4487a9: move all image and icon strings to theme file

Summary

Move all icon and image definitions to theme file and make some consistency fixes.
In anticipation of a colorized version of the artist image, there are two definitions which currently hold the same icon.
Also enables the display of a default cover in context view.

Test Plan

no icon issues throughout the app

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Jan 6 2018, 9:33 AM

astippich created this revision.

Reading a little bit more about how platform specific files work, all those changes must be carried over to the windows theme file, otherwise the windows build will break. Correct?

In D9697#187212, @astippich wrote:

Reading a little bit more about how platform specific files work, all those changes must be carried over to the windows theme file, otherwise the windows build will break. Correct?

Yes, this is the idea. I should have used that when solving a contrast problem on windows without breaking dark theme on linux.

mgallien accepted this revision.Jan 8 2018, 9:41 PM

This revision is now accepted and ready to land.Jan 8 2018, 9:41 PM

Thanks for your work.
This should be much easier now to have a solution for having bundled icons when not having kdeclarative as a dependency.

Closed by commit R255:c0890f4487a9: move all image and icon strings to theme file (authored by astippich). · Explain WhyJan 9 2018, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/ContextView.qml (4 lines)
M			src/HeaderBar.qml (16 lines)
M			src/MediaAlbumDelegate.qml (2 lines)
M			src/MediaAlbumView.qml (2 lines)
M			src/MediaArtistAlbumView.qml (2 lines)
M			src/MediaArtistDelegate.qml (4 lines)
M			src/MediaTrackDelegate.qml (2 lines)
M			src/PlayListEntry.qml (2 lines)
M			src/Theme.qml (9 lines)
M			src/ViewSelector.qml (8 lines)
M			src/windows/WindowsTheme.qml (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24818	3c42e8f		Jan 6 2018, 9:33 AM	★	★
Diff 2	25039	0cede69	R255:c0890f4487a9a44105ee7f74fde12bb3b544d959	Jan 9 2018, 6:53 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e4623b773d4d	841bd94d5777	b0bef6100365	Alexander Stippich	consistency fixes	Jan 6 2018, 9:29 AM
b0bef6100365	be636bbfcd4e	708f0ea7dccf 3c42e8f370bb	Alexander Stippich	Merge branch 'master' into icons_and_images	Jan 6 2018, 9:20 AM
708f0ea7dccf	2ada139271c7	d848859c9de1	Alexander Stippich	fix display of default cover in context view	Dec 23 2017, 10:49 AM
d848859c9de1	f385a74c32e0	46a9d06b1dcc	Alexander Stippich	move all image and icon strings to theme file	Dec 23 2017, 10:11 AM