Differential D9640

[Folder View] Explicitly reject Firefox tab drops
ClosedPublic
Actions

Authored by broulik on Jan 3 2018, 2:12 PM.

Details

Reviewers
hein
mart
Group Reviewers
Plasma
Commits
R119:ab007182ad3e: [Desktop Containment] Explicitly reject Firefox tab drops
Summary

This is a real-world fix for a long-standing issue.
Mime-type determination and everything is asynchronous, so we cannot know in advance whether to accept or reject the drop.

BUG: 337711
FIXED-IN: 5.12.0

Test Plan

I can now detach Firefox windows properly even with no windows in front of my desktop with widgets unlocked

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 3 2018, 2:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2018, 2:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 3 2018, 2:12 PM
ngraham added a subscriber: ngraham.Jan 3 2018, 5:08 PM
mart accepted this revision.Jan 9 2018, 2:08 PM
This revision is now accepted and ready to land.Jan 9 2018, 2:08 PM
Closed by commit R119:ab007182ad3e: [Desktop Containment] Explicitly reject Firefox tab drops (authored by broulik). · Explain WhyJan 9 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25024

View Options

containments/desktop/package/contents/ui/main.qml

Loading...