Differential D9609

Explicitly pass iconNameForUrl when dropping places entry
ClosedPublic
Actions

Authored by broulik on Jan 2 2018, 1:05 PM.

Details

Reviewers
apol
Group Reviewers
Dolphin
Commits
R318:dedb612764cf: Explicitly pass iconNameForUrl when dropping places entry
Test Plan

Forgot that aspect when I did D3896

Dropped my Music folder to places panel, it was created with proper folder-music icon. Dropped Music and Documents to places, both got their correct specific icon

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik requested review of this revision.Jan 2 2018, 1:05 PM
broulik created this revision.
apol accepted this revision.Jan 11 2018, 3:07 PM
apol added a subscriber: apol.

LGTM

This revision is now accepted and ready to land.Jan 11 2018, 3:07 PM
Closed by commit R318:dedb612764cf: Explicitly pass iconNameForUrl when dropping places entry (authored by broulik). · Explain WhyJan 11 2018, 3:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24586

View Options

src/panels/places/placesitemmodel.cpp

Loading...