Differential D3896

Explicitly pass iconNameForUrl when creating new places entry
ClosedPublic
Actions

Authored by broulik on Dec 31 2016, 9:13 PM.

Details

Reviewers
emmanuelp
Group Reviewers
Dolphin
Commits
R318:996f8520e700: Explicitly pass iconNameForUrl when creating new places entry
Summary

KIO already depends on KBookmarks so it can't depend the other way round.
Together with D3895 this will ensure that adding special user locations (e.g. Documents or Pictures) folder will get the proper icon, rather than generic folder icon.

Test Plan

Added my Videos folder to places, it automatically had the correct folder icon now

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9567.Dec 31 2016, 9:13 PM
broulik retitled this revision from to Explicitly pass iconNameForUrl when creating new places entry.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Dolphin, emmanuelp.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp accepted this revision.Jan 1 2017, 6:17 PM
emmanuelp edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2017, 6:17 PM
Closed by commit R318:996f8520e700: Explicitly pass iconNameForUrl when creating new places entry (authored by broulik). · Explain WhyJan 3 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphincontextmenu.cpp (5 lines)

Diff 9635

View Options

src/dolphincontextmenu.cpp

Loading...