We originally wanted to wait for feedback whether this needs to be configurable and also with KDE's privacy vision statement, there's clearly demand for such a setting.
BUG: 384264
FIXED-IN: 5.12.0
Details
Details
- Reviewers
graesslin davidedmundson - Group Reviewers
Plasma VDG
Enabled and disabled media controls.
Diff Detail
Diff Detail
- Repository
- R133 KScreenLocker
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I think the change is needed and makes sense.
There's a logic bug though.
| kcm/kcm.cpp | ||
|---|---|---|
| 136 ↗ | (On Diff #24567) | This won't work. Kpacakges don't inherit metadata, so I think if you changed to breeze-dark you'd get the controls but lose the ability to turn them off. But also you can't just iterate through parent packages metadata either, what if someone inherited Breeze but then *did* replace the lockscreen. I can't think of anything that'll work, other than just adding "if available" to the config label and skipping this. |
| kcm/kcm.cpp | ||
|---|---|---|
| 136 ↗ | (On Diff #24567) | maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme. |
| kcm/kcm.cpp | ||
|---|---|---|
| 136 ↗ | (On Diff #24567) |
Okay… that was the main reason I didn't add this months ago |
Comment Actions
maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme.
I like half of that.
I think configuring the look and feel package somewhere separate would be a very weird user experience.
You'd want to configure things for the lockscreen in the lockscreen.
But, having the lnf provide the config makes sense.
If we added a screenlocker config to the lnf and then loaded that in this UI in the same way that we do wallpapers that would be perfect.