Differential D9684

Load config specified by the LnF theme
ClosedPublic
Actions

Authored by davidedmundson on Jan 5 2018, 6:29 PM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R133:e36101cd1b48: Load config specified by the LnF theme

Summary

This is loaded in a QQuickView like the wallpaper, rest of the code is
mostly based on something quite similar.

Only differences is that wallpapers packages can change during the
config, whereas the base package cannot; which simplifies some code.

BUG: 384264

Test Plan

Started playing some tunes
Locked screen, still had my controls
Changed setting
Locked screen, didn't have my controls
Changed wallpaper to confirm I hadn't broken anything

Diff Detail

Repository

R133 KScreenLocker

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Jan 5 2018, 6:29 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 5 2018, 6:29 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jan 5 2018, 6:29 PM

Remove unintended change to .ui file

Debug--

I like it!

I like that a lot.

broulik accepted this revision.Jan 8 2018, 11:19 AM

This revision is now accepted and ready to land.Jan 8 2018, 11:19 AM

zzag added a subscriber: zzag.Jan 8 2018, 12:35 PM

zzag added inline comments.

greeter/lnf_integration.cpp
63	Maybe it should be deleted.

Closed by commit R133:e36101cd1b48: Load config specified by the LnF theme (authored by davidedmundson). · Explain WhyJan 8 2018, 1:13 PM

This revision was automatically updated to reflect the committed changes.

broulik mentioned this in D9601: Make media controls configurable.Jan 10 2018, 5:09 PM

Revision Contents
Changeset List

		Path
M		greeter/CMakeLists.txt (1 line)
M		greeter/greeterapp.h (3 lines)
M		greeter/greeterapp.cpp (12 lines)
A	M	greeter/lnf_integration.h (83 lines)
A	M	greeter/lnf_integration.cpp (74 lines)
M		kcm/CMakeLists.txt (1 line)
P		kcm/config.qml Deleted after being copied to multiple locations: kcm/lnfconfig.qml kcm/wallpaperconfig.qml
M		kcm/kcm.h (10 lines)
M		kcm/kcm.cpp (45 lines)
M		kcm/kcm.ui (37 lines)
P		kcm/lnfconfig.qml (13 lines) Copied from kcm/config.qml
M		kcm/resources.qrc (3 lines)
V		kcm/{wallpaperconfig.qml ← config.qml}

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24787	12ecfbf		Jan 5 2018, 6:29 PM	★	★
Diff 2	24788	12ecfbf	Remove unintended change to .ui file	Jan 5 2018, 6:32 PM	★	★
Diff 3	24791	12ecfbf	Debug--	Jan 5 2018, 6:38 PM	★	★
Diff 4	24938	d0db157	R133:e36101cd1b4857a23e05b9d1f039e9358bd1f49b	Jan 8 2018, 1:13 PM	★	★