Differential D9400

use kpackage_install_bundled_package
ClosedPublic
Actions

Authored by mart on Dec 18 2017, 4:28 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R242:7af18926322e: use kpackage_install_bundled_package
Summary

use the new package install macro to install them as
as rcc files

Test Plan

plasmashell starts and most plasmoids seem to work,
still needed a more thorough test

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Dec 18 2017, 4:28 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 18 2017, 4:28 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart requested review of this revision.Dec 18 2017, 4:28 PM
apol added a subscriber: apol.Dec 18 2017, 4:32 PM

I'd prefer a patch that ports plasma-workspace/desktop to kpackage_install_bundled_package rather than abstracting through plasma_install_package.

mart added a comment.Mar 20 2018, 12:37 PM

using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids" ${PLASMA_RELATIVE_DATA_INSTALL_DIR})

I would still go with this form.

davidedmundson added a subscriber: davidedmundson.Mar 20 2018, 12:46 PM

My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes.

mart added a comment.Mar 20 2018, 1:40 PM
In D9400#229866, @davidedmundson wrote:

My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes.

what about doing a second plasma macro plasma_install_bundled_package?

mart updated this revision to Diff 29993.Mar 20 2018, 1:56 PM

2 macros

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2018, 1:57 PM
Closed by commit R242:7af18926322e: use kpackage_install_bundled_package (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.
apol added a comment.Mar 20 2018, 2:12 PM
In D9400#229861, @mart wrote:

using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids" ${PLASMA_RELATIVE_DATA_INSTALL_DIR})

I would still go with this form.

FWIW, we should be able to infer if it's a plasmoid (i.e. root) from the metadata.desktop file, AFAIR.

Revision Contents
Changeset List

PathPackages
MKF5PlasmaMacros.cmake (13 lines)

Diff 29994

View Options

KF5PlasmaMacros.cmake

Loading...