Created 'GroupHiddenRole' for KPlacesModel
ClosedPublic

Authored by renatoo on Dec 8 2017, 1:20 PM.

Details

Summary

Created new role ''GroupHiddenRole' for 'KPlacesModel'

Test Plan

unit test

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
renatoo created this revision.Dec 8 2017, 1:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 8 2017, 1:20 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
renatoo requested review of this revision.Dec 8 2017, 1:20 PM
renatoo edited the summary of this revision. (Show Details)Dec 8 2017, 1:21 PM
renatoo added a reviewer: mwolff.
mwolff accepted this revision.Dec 8 2017, 1:24 PM

you could reduce the code duplication by adding a loop. Note that you can even write something like this:

for (auto type : {type1, type2, type3}) {
   ....
}
autotests/kfileplacesmodeltest.cpp
1242

nest this in an outer loop over the group types to share most of the code

This revision is now accepted and ready to land.Dec 8 2017, 1:24 PM
renatoo updated this revision to Diff 23647.Dec 8 2017, 1:35 PM

Refactored unit test

renatoo marked an inline comment as done.Dec 8 2017, 1:36 PM
Closed by commit R241:561210cd18c9: Created 'GroupHiddenRole' for KPlacesModel (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyDec 8 2017, 1:49 PM
This revision was automatically updated to reflect the committed changes.
mwolff added a comment.Dec 8 2017, 1:56 PM

thanks lgtm