On arm64 e.g SYS_open and few more syscalls are not available, this
results in build failure.
Details
Details
- Reviewers
fvogt graesslin davidedmundson - Group Reviewers
Plasma - Commits
- R133:f1a1c9b22e4f: Fix building autotest on platforms where syscalls are not available
builds locally
Diff Detail
Diff Detail
- Repository
- R133 KScreenLocker
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| greeter/autotests/seccomp_test.cpp | ||
|---|---|---|
| 103–104 | Why is this not guarded? | |
| greeter/autotests/seccomp_test.cpp | ||
|---|---|---|
| 103–104 | Those methods are available in fcntl whether syscalls are defined or not. | |
Comment Actions
I think you also need to adjust the actual seccomp filtering. I don't know whether the filter works at all if the syscalls don't exist.
Comment Actions
It uses SCMP_SYS to get the syscall nrs. So it would fail to build. If with this patch kwin builds and tests run fine, it's ok.
I doubt it though.
Comment Actions
Can I submit this revision first and follow up with another later if filter is not working? Because currently it is not building on arm64 at all and I have no other way to test it without it getting build.
Comment Actions
Can I submit this revision first and follow up with another later if filter is not working? Because currently it is not building on arm64 at all and I have no other way to test it without it getting build.
I'll test it
Comment Actions
Just adding my 2 cent: I think the filter should work fine, as SCMP_SYS is explicit available to support different platforms. If the syscall isn't available, it uses negative pseudo syscall numbers to ignore those syscalls.