Don't set a window icon in Plasma::Dialog
ClosedPublic

Authored by hein on Dec 5 2017, 5:04 PM.

Details

Summary

Setting a window icon is costly enough to be worth avoiding when it's
not actually needed.

This is a resurrection of David's old patch:

https://git.reviewboard.kde.org/r/128484/

The concerns in the old discussion that led to its rejection are no
longer valid today: In the meantime we implemented a way for apps to
announce their .desktop file in a window hint, which KWin (and libtm)
will fall back to to look up an icon if not set. As plasmashell does
this, we can drop the setIcon call here and won't regress.

Test Plan

The pinned systray popup dialog still gets the Plasma icon in the
Present Windows effect.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Dec 5 2017, 5:04 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 5 2017, 5:04 PM
hein requested review of this revision.Dec 5 2017, 5:04 PM
broulik added a subscriber: broulik.Dec 5 2017, 5:20 PM

+1

I still get an icon for plasma popups in tabbox and present windows

graesslin accepted this revision.Dec 5 2017, 5:24 PM
This revision is now accepted and ready to land.Dec 5 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.