Differential D9107

Add undo support to BatchRenameJob
ClosedPublic
Actions

Authored by chinmoyr on Dec 2 2017, 2:18 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:befcbbd4e36b: Add undo support to BatchRenameJob
Summary

This patch makes undoing a batch rename possible.

Depends on D9103

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chinmoyr created this revision.Dec 2 2017, 2:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 2 2017, 2:18 PM
chinmoyr requested review of this revision.Dec 2 2017, 2:18 PM
dfaure requested changes to this revision.Dec 2 2017, 2:46 PM

Good stuff.

autotests/fileundomanagertest.cpp
697

use .at(0) to avoid detaching

src/widgets/fileundomanager.h
136–138

add docu for BatchRename

This revision now requires changes to proceed.Dec 2 2017, 2:46 PM
chinmoyr updated this revision to Diff 23290.Dec 2 2017, 4:43 PM
chinmoyr marked 2 inline comments as done.

minor changes

dfaure accepted this revision.Dec 2 2017, 5:09 PM
This revision is now accepted and ready to land.Dec 2 2017, 5:09 PM
aspotashev added a subscriber: aspotashev.Dec 2 2017, 7:23 PM

Please don't push this while in string freeze because you added a new translatable ('i18n()') message.

https://community.kde.org/Schedules/Frameworks

dfaure added a comment.Dec 3 2017, 9:47 AM

The RC is tagged, you can push.

Closed by commit R241:befcbbd4e36b: Add undo support to BatchRenameJob (authored by chinmoyr). · Explain WhyDec 3 2017, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23340

View Options

autotests/fileundomanagertest.h

Loading...
View Options

autotests/fileundomanagertest.cpp

Loading...
View Options

src/widgets/fileundomanager.h

Loading...
View Options

src/widgets/fileundomanager.cpp

Loading...
View Options

src/widgets/fileundomanager_p.h

Loading...