Add the description tag to the generated pkgconfig files
ClosedPublic
Actions

Authored by krop on Nov 29 2017, 4:21 PM.

Details

Reviewers

dfaure
apol

Commits

Summary

pkgconfig complains when the .pc file doesn't have a description. eg:
$ pkg-config Baloo
Package 'Baloo' has no Description: field

With this change, if the DESCRIPTION parameter is not used,
ECM_GENERATE_PKGCONFIG_FILE will :

create a description based on the LIB_NAME value

Test Plan

Tests added & pass

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript

krop requested review of this revision.Nov 29 2017, 4:21 PM

This revision is now accepted and ready to land.Nov 30 2017, 6:34 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		modules/ECMGeneratePkgConfigFile.cmake (22 lines)
M		tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc (1 line)
A	M	tests/ECMGeneratePkgConfigFile/KF5CoreAddons2.pc (7 lines)
A	M	tests/ECMGeneratePkgConfigFile/KF5CoreAddons3.pc (7 lines)
A	M	tests/ECMGeneratePkgConfigFile/metainfo_with_description.yaml (21 lines)
A	M	tests/ECMGeneratePkgConfigFile/metainfo_with_empty_description.yaml (21 lines)
A	M	tests/ECMGeneratePkgConfigFile/metainfo_without_description.yaml (20 lines)
M		tests/ECMGeneratePkgConfigFile/run_test.cmake.config (57 lines)