[Calendar] Adjust the calendar toolbar anchors
ClosedPublic

Authored by akulichalexandr on Nov 27 2017, 3:03 PM.

Details

Summary

Horizontally align the toolbar row to the days/month/etc grid canvas.

(The bar was used to be a few pixels wider)

Test Plan

Before:

After:

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 27 2017, 3:03 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

Updating D9019: Plasma: Adjust the calendar toolbar layout

The new diff is created via Arcanist

akulichalexandr retitled this revision from Plasma: Adjust the calendar toolbar layout to [Calendar] Adjust the calendar toolbar anchors.Nov 27 2017, 3:22 PM
akulichalexandr edited the summary of this revision. (Show Details)
akulichalexandr edited the test plan for this revision. (Show Details)Nov 27 2017, 3:43 PM
akulichalexandr edited the test plan for this revision. (Show Details)Nov 27 2017, 4:06 PM
broulik accepted this revision.Nov 27 2017, 4:40 PM
broulik added a subscriber: broulik.

Thanks! It's the little things that make it feel polished :)

Do you have commit access?

This revision is now accepted and ready to land.Nov 27 2017, 4:40 PM

Thanks! It's the little things that make it feel polished :)

Do you have commit access?

Yes, I have the access, but I did not contribute for a long time and still have to get used to Phabricator.
Thank you for the review, I'll push the commit once I'll figure out how to do it properly nowadays. :-)

but I did not contribute for a long time

Good to have you back!

aacid added a subscriber: aacid.Jan 5 2018, 10:10 PM

Thanks! It's the little things that make it feel polished :)

Do you have commit access?

Yes, I have the access, but I did not contribute for a long time and still have to get used to Phabricator.
Thank you for the review, I'll push the commit once I'll figure out how to do it properly nowadays. :-)

Since you seem to have used arc properly, this will do

arc patch D9019
arc land

I can do it for you if you want

This revision was automatically updated to reflect the committed changes.