Differential D8965

[PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu
ClosedPublic
Actions

Authored by broulik on Nov 23 2017, 1:32 PM.

Details

Reviewers
fvogt
davidedmundson
Group Reviewers
Plasma
Commits
R242:facaaf93d016: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu
Summary

This ensures the menu can have nice round corners with Breeze and Oxygen. The same had already been done in ContainmentInterface's menu.

CHANGELOG: Fixed an issue where PlasmaComponents Menu would appear with broken corners

CCBUG: 381799

Test Plan

Before


After

The effect is barely noticeable with Breeze as it has only a 1px border but it is still there and also fixed with this patch.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 23 2017, 1:32 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptNov 23 2017, 1:32 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the summary of this revision. (Show Details)Nov 23 2017, 1:33 PM
davidedmundson accepted this revision.Nov 23 2017, 1:33 PM
This revision is now accepted and ready to land.Nov 23 2017, 1:33 PM
Closed by commit R242:facaaf93d016: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu (authored by broulik). · Explain WhyNov 24 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22826

View Options

src/declarativeimports/plasmacomponents/qmenu.cpp

Loading...