derive app version from kde applications release
ClosedPublic

Authored by sitter on Nov 22 2017, 10:32 AM.

Details

Summary

makes versions more consistent between tarball - distros - in-app

Test Plan

correct version in about dialog

Diff Detail

Repository
R352 Filelight
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 22 2017, 10:32 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 22 2017, 10:32 AM

What about using ecm_setup_version ?

sitter updated this revision to Diff 22724.Nov 22 2017, 11:26 AM

FTR I think this makes 0 valuable difference with the use case at hand. All it does is hide the available macro names.

adridg accepted this revision.Dec 6 2017, 6:25 PM
adridg added a subscriber: adridg.

Seems sensible from a packaging and release standpoint, so I'll say "LGTM", but I don't really like it from an application-versioning standpoint since releases happen regularly regardless of changes in the application itself.

This revision is now accepted and ready to land.Dec 6 2017, 6:25 PM

releases happen regularly regardless of changes in the application itself.

Very true, the way I see it these releases may contain changed/new translations though. So from a translator's POV it did change and from a coders POV it is hard to know if that *will be* the case for the next release (what with translation only getting added during tarballing at which point it's too late to bump the version). It's ultimately a higher level problem, no-change version bumps are in a way just a symptom of no-change tarball releases, without the latter the former wouldn't happen.

This revision was automatically updated to reflect the committed changes.