General HiDPI enablement for Gwenview's importer
ClosedPublic

Authored by rkflx on Nov 20 2017, 4:15 PM.

Details

Summary

This is a follow-up patch to 43f6e15237f3, which enabled HiDPI in the UI
of Gwenview's main app.

Note: Thumbnails are still pixelated as this is not yet fixed in the
respective Gwenview component.

Solves issue 2. in D7581#163655.

Test Plan

Standard icons all over the UI not pixelated anymore for
QT_SCALE_FACTOR=1.5 gwenview_importer .

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Nov 20 2017, 4:15 PM
rkflx retitled this revision from General HiDPI enablement for Gwenviews's importer to General HiDPI enablement for Gwenview's importer.Nov 20 2017, 4:16 PM
rkflx added a comment.Nov 27 2017, 5:05 PM

I guess this patch is too trivial to review, so I'll just commit tomorrow unless someone discovers any critical issues.

hetzenecker accepted this revision.Nov 27 2017, 5:11 PM
This revision is now accepted and ready to land.Nov 27 2017, 5:11 PM

Don't know if I have the permission to officially review changes, but I can confirm this improves things. :-)

This revision was automatically updated to reflect the committed changes.

Don't know if I have the permission to officially review changes, but I can confirm this improves things. :-)

And I don't know whether I have permission to just commit :) Asking the resident HiDPI expert was the best I could do, I don't think there are any other reviewers around for Gwenview (unless I manually add someone, which I did…). So yes, if someone adds you as a reviewer, do your best to review (or resign, if you cannot ATM).

It's a do-ocracy around here: if you're willing to put in the time and the work is of good quality, people don't seem to complain!