- Group Reviewers
- Maniphest Tasks
- T7244: Fonts (somewhere in branch)
- R119:e7032a030b83: needssave only when settings actually changed
R119:24b960f92284: QML port of fonts kcm
tried all the options
Can you mark this as "Fixes T7244", so that task will be automatically closed when this goes in?
FWIW, the list of all KCM redesign tasks can be found at https://phabricator.kde.org/tag/plasma_kcm_redesign/
Instead of always setting this to true in a prop setter, you need to implement a method that checks whether the new value is actually different from the stored configuration and then sets true or false based on that. Otherwise you are turning on the 'Apply' button but never turning it off again. Cf. LaunchFeedback::updateNeedsSave() in D8911.
This and similar bindings will break when the user changes the spinbox value, so after a manual adjustment e.g. defaults() won't work any longer. It needs a seperate Connections à la D8911.