remove extractor based on QtMultimedia
ClosedPublic

Authored by mgallien on Nov 18 2017, 4:54 PM.

Details

Summary

It is not working well and do not provide much advantages on Linux and Windows platforms

It is based on QMediaPlayer and that is not playing well with sound
volume applet for example.

Test Plan

still compile and run test from taglib extractor

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien created this revision.Nov 18 2017, 4:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 18 2017, 4:54 PM
dfaure accepted this revision.Dec 2 2017, 10:30 AM
dfaure added a subscriber: dfaure.

Your call. But since that would also fix CI, I'm in favour.

This revision is now accepted and ready to land.Dec 2 2017, 10:30 AM
mgallien added a comment.EditedDec 3 2017, 9:33 PM

Your call. But since that would also fix CI, I'm in favour.

I did read the code of Qt in the gstreamer support and it seems that it is not possible to get metadata outside a QMediaPlayer. I think that this is problematic when using common desktop environment (sound volume applet listing a player when scanning music, ...).
I prefer to say that I was wrong when pushing the code than trying to modify Qt feature (for lack of time).

This revision was automatically updated to reflect the committed changes.