fix crash on Windows when deleting an instance of QtMultimediaExtractor
AbandonedPublic

Authored by mgallien on Jun 21 2017, 3:25 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Summary

one should delete the QMediaPlayer in the owner thread to avoid crash

Test Plan

Tested with visual studio 2015 build on Windows

Diff Detail

Repository
R286 KFileMetaData
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mgallien created this revision.Jun 21 2017, 3:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 21 2017, 3:25 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mgallien edited reviewers, added: Frameworks; removed: kde-frameworks-devel.Sep 9 2017, 8:16 PM
davidedmundson accepted this revision.Oct 5 2017, 9:37 AM
davidedmundson added a subscriber: davidedmundson.

Can't you just parent the extractor to the mRunnerThread?
Would be all round cleaner

This revision is now accepted and ready to land.Oct 5 2017, 9:37 AM

The problem is that, on Windows, internal objects of QMediaPlayer need to be destroyed in the context of the thread where they have been created. I am not sure making mMetadataExtractor have mRunnerThread as its parent will help on that.
I can test but have no Windows around currently to do the test.

Sorry for the delay, currently I have no easy access to a development computer running Windows.
David, I am afraid I have not understood correctly your suggestion. Did you suggest to make mMetadataExtractor have its thread as Qt parent ?

mgallien abandoned this revision.Nov 18 2017, 4:55 PM

I do not have time to properly work on that. See D8886 .