BUG: 387036
Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).
Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.
apol |
Discover Software Store |
BUG: 387036
Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).
Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.
Tested in KDE Neon. Package changelogs are now fully visible without being in a tiny scrollview:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Can't the changelog become utterly long? Perhaps a popup/overlay sheet thing would be more appropriate
Won't this introduce other usability issues? :/
WRT the patch, it's fine, just remove the RowLayout and put its properties into the label
If the changelog is like a thousand lines long, you can always just close it again. And I think it would actually be easier to read as one huge box than a tiny scrollview that only shows like 5 lines at a time.
Another option would be that clicking on a package takes you to another view or overlay (like Kai suggested), but that would be more involved and you would lose the ability to quickly see the changelogs for multiple packages.
What's the point of having the "open" button if this scrollview is accepted? After all, you won't see much more if you click open and an install button and a package description.
IMHO the open button is superfluous for package updates anyway. It takes you to a view that doesn't even show you the changelogs.
Perhaps what we should do is the following:
That's a more involved change than I'm going to be able to make right now though. But I think it would be a nice improvement.
Also change "Open" button to say "More Information..." (it's not clear what you were opening before)
@apol Thanks! I made one more change (the text of the "Info") button; does your approval still hold?