Fix testtrash with qtbase 5.10 beta 4
ClosedPublic

Authored by elvisangelaccio on Nov 16 2017, 10:00 AM.

Details

Summary

Same fix as in D8836, this time for testtrash.

Test Plan

Run testtrash.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 16 2017, 10:00 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Nov 16 2017, 10:01 AM
This revision is now accepted and ready to land.Nov 16 2017, 10:01 AM

Maybe we need a KUrl class :-)
Just kidding.

More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl.

Elvis, how many other issues like this do we expect to crop up due to Qt 5.10?

Elvis, how many other issues like this do we expect to crop up due to Qt 5.10?

I have two other failing tests in kio, which I'm fixing now. I guess this change will probably break something in some applications, but that's hard to tell.

krop added a subscriber: krop.Nov 16 2017, 10:43 AM

Elvis, how many other issues like this do we expect to crop up due to Qt 5.10?

https://bugs.kde.org/386420 ?

This revision was automatically updated to reflect the committed changes.

The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise?

The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise?

Imho yes, better CI coverage is always a good thing :)

Following other feedback i've received the gears of motion for such a thing are in motion.