Differential D8640

[KDirModel] Emit change for HasJobRole when jobs change
ClosedPublic
Actions

Authored by broulik on Nov 3 2017, 1:50 PM.

Details

Reviewers
dfaure
hein
mwolff
Group Reviewers
Frameworks
Commits
R241:c38db223613f: [KDirModel] Emit change for HasJobRole when jobs change
Test Plan

I now have QML update live when a copy job comes and goes

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 3 2017, 1:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 3 2017, 1:50 PM
dfaure requested changes to this revision.Nov 5 2017, 8:44 PM
dfaure added inline comments.
src/widgets/kdirmodel.cpp
696 ↗(On Diff #21835)

constBegin() / constEnd(), on the non-const m_allCurrentDestUrls, to avoid a detach?

703 ↗(On Diff #21835)

You should use indexForNode() instead, to cover the case of the root URL, and to set the proper internal pointer in the index (for tree models).

This revision now requires changes to proceed.Nov 5 2017, 8:44 PM
broulik updated this revision to Diff 21954.Nov 6 2017, 11:33 AM
  • constBegin() on m_allCurrentDestUrls
  • Use indexForNode
dfaure accepted this revision.Nov 14 2017, 8:11 AM
This revision is now accepted and ready to land.Nov 14 2017, 8:11 AM
Closed by commit R241:c38db223613f: [KDirModel] Emit change for HasJobRole when jobs change (authored by broulik). · Explain WhyNov 15 2017, 9:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdirmodel.cpp (15 lines)

Diff 21954

View Options

src/widgets/kdirmodel.cpp

Loading...