[platforms/drm] Restore previous mode if an atomic test fails
ClosedPublic
Actions

Authored by graesslin on Nov 1 2017, 6:23 PM.

Details

Reviewers

romangg
davidedmundson

Group Reviewers

KWin
Plasma

Commits

R108:26cdfd317fc8: [platforms/drm] Restore previous mode if an atomic test fails

Summary

When KWin successfully presents a new mode, it stores the current state
as the last working mode. If a new modeset is requested and the atomic
test fails, all is undone and reverted to this last knowing mode.

Currently included are:

the mode
global position
transformation

This is only done on a modeset not when going to DPMS.

Test Plan

Selected the not working vertical rotation and nothing bad
happened.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Nov 1 2017, 6:23 PM

Restricted Application added a project: KWin. · View Herald TranscriptNov 1 2017, 6:23 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added dependencies: D8578: [platforms/drm] Forward the mode changes to the OutputInterface, D8582: [platforms/drm] Add support for rotation property on the Plane.Nov 1 2017, 6:24 PM

ngraham added a subscriber: ngraham.Nov 1 2017, 6:48 PM

graesslin added a dependent revision: D8627: [platforms/drm] Properly adjust cursor position on a rotated output.Nov 2 2017, 5:15 PM

davidedmundson added a subscriber: davidedmundson.Nov 2 2017, 5:40 PM

davidedmundson added inline comments.

plugins/platforms/drm/drm_output.cpp
916	we need to communicate this reset back to waylandOutput/waylandOutputDevice

graesslin added inline comments.Nov 2 2017, 6:42 PM

plugins/platforms/drm/drm_output.cpp
916	Yes and for that there is a TODO a few lines below. But it doesn't make any sense to implement it before D8578 is merged.

davidedmundson accepted this revision.Nov 3 2017, 10:02 AM

This revision is now accepted and ready to land.Nov 3 2017, 10:02 AM

Closed by commit R108:26cdfd317fc8: [platforms/drm] Restore previous mode if an atomic test fails (authored by graesslin). · Explain WhyNov 5 2017, 8:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/drm_object_plane.h (1 line)
M			plugins/platforms/drm/drm_object_plane.cpp (5 lines)
M			plugins/platforms/drm/drm_output.h (10 lines)
M			plugins/platforms/drm/drm_output.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21725	9519b7e		Nov 1 2017, 6:23 PM	★	★
Diff 2	21890	b2d8bbe	R108:26cdfd317fc87b024ebcd9c2adefc86cfd59504e	Nov 5 2017, 8:21 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
72612a9dd644	06c19349b02e	9519b7e8ed87	Martin Flöser	[platforms/drm] Restore previous mode if an atomic test fails (Show More…)	Nov 1 2017, 6:21 PM

Status	Author	Revision
Closed	graesslin	D8594 [platforms/drm] Rotate screen if requested from KScreen
Closed	graesslin	D8627 [platforms/drm] Properly adjust cursor position on a rotated output
Closed	graesslin	D8602 [platforms/drm] Restore previous mode if an atomic test fails
Closed	graesslin	D8578 [platforms/drm] Forward the mode changes to the OutputInterface
Closed	graesslin	D8582 [platforms/drm] Add support for rotation property on the Plane