Differential D8534

DictEngine: set a scheme for the URLs, otherwise webengine won't handle them
ClosedPublic
Actions

Authored by dfaure on Oct 28 2017, 8:42 AM.

Details

Reviewers
davidedmundson
broulik
mart
Group Reviewers
Plasma
Commits
R120:208ad519efa8: DictEngine: set a scheme for the URLs, otherwise webengine won't handle them
Summary

AFAICS the only other user for the engine (other than the applet I'm
porting) is the runner for KRunner, where links don't work anyway.

Port to QRegularExpression while at it.

Test Plan

Tested with the upcoming dict applet.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Oct 28 2017, 8:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2017, 8:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure updated this revision to Diff 21496.Oct 28 2017, 3:59 PM

Remove now unnecessary C++11 literal syntax

mart accepted this revision.Oct 30 2017, 2:31 PM
This revision is now accepted and ready to land.Oct 30 2017, 2:31 PM
Closed by commit R120:208ad519efa8: DictEngine: set a scheme for the URLs, otherwise webengine won't handle them (authored by dfaure). · Explain WhyOct 30 2017, 4:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdataengines/dict/dictengine.cpp (24 lines)

Diff 21579

View Options

dataengines/dict/dictengine.cpp

Loading...