Cleaned up and standardized Spectacle's Settings page, which was a bit bloated with unnecessary information and nonstandard formatting, terminology, and icons, and lacked any room to add any new settings (such as one for 372408)
Details
Details
- Reviewers
broulik abetts bgupta jensreuterberg - Group Reviewers
Spectacle KDE Applications VDG - Commits
- R166:02ce6a91d2d3: Clean up and standardize Settings dialog
Tested in KDE Neon; all options still work, and Docbook is up to date with the new item labels. The best way to see what this patch does is to just look at before-and-after screenshots:
General page before:
General page after:
Save page before:
Save page after:
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think most options are self-descriptive and thus do not warrant a GUI description. +1 from me overall but perhaps add Usability/VDG.
Comment Actions
@bgupta, I'm adding you since this was originally your design. I don't want to step on your toes, and I see what you were going for with the long descriptions, but they are currently so long that it effectively presents ever adding any other options here because the window would become too tall. I think we can safely remove the separate descriptions if we name the checkboxes descriptively enough.
Comment Actions
That is a good cleanup. I would also encourage you to take inspiration from the settings mockups that I made. Where titles and fields are centered aligned. Just to see if it looks good.
Comment Actions
I'd definitely consider that, but as a part of a larger effort (I would definitely submit patches). For this, I was trying to mimic existing styles so as not to provoke too much controversy. :)
Comment Actions
I have no objections with this changes. Some parts might need alignment help, just to finish it up. Alignment HIG. I have no objections otherwise.