Related to patch https://phabricator.kde.org/D7047 . Pointed out by @ngraham
Make a new option called "Edge filling". Users can choose either "Blur image" or "Solid color". They are only visible when the image filling mode is "Center" or "Scale and keep ratio".
When it is "Center":
When it is "Tile":
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| wallpapers/image/imagepackage/contents/ui/config.qml | ||
|---|---|---|
| 161 | This used to be the case, then it was changed for some obscure use case with transparaent images. | |
| wallpapers/image/imagepackage/contents/ui/config.qml | ||
|---|---|---|
| 161 | Ah, I have never thought about this. Is this use case common? I have never seen people use transparent image for wallpaper. Usually it is some photos or JPG images downloaded from internet. This brings another problem. Blur image edge filling doesn't work well with transparent images. For transparent image you always need a background color. I am lost... If we say, we only support opaque image, the solution is much simpler. | |
| wallpapers/image/imagepackage/contents/ui/config.qml | ||
|---|---|---|
| 161 | I suppose we could also show the radio buttons if we detect that the image has transparency. But yeah, it would be nice if we can only support opaque images. It also hadn't occurred to me that anyone would use an image with transparency, and I don't know if I've ever seen such a thing in the wild. But of course users can be surprising! :) | |
I don't know which word is better because I am not a native English speaker. But yeah, I can change it.
Big +1 from me, if we can resolve the potential issue with images that have transparency.
You need to adjust the config.xml for that setting to persist.
Also, it seems you have pushed an unfinished version of that feature [1] without approval.
[1] https://cgit.kde.org/plasma-workspace.git/commit/?id=9923cde1024dc86ab14c200bf745dde308fc9d3f
It was approved in another Diff https://phabricator.kde.org/D7047 . But I forgot to use arc land to commit...
Heh I may be the one who used transparent images - the idea being that you could, in theory set colour of an entire wallpaper based on icon colour using the correct kind of transparent image (essentially making darker parts less transparent meaning the lighter the area the brighter the underlying colour, creating a monochromatic image). To be quite frank as an idea it demanded slightly more work than was feasible, so I support this.
A neat idea, but yeah, I think it probably wouldn't even occur to most people to try to use a transparent image! If you approve, would you mind formally accepting it? I'm willing to triage and handle any bugs that come in saying "Hey, you broke my transparent wallpaper!"
Sure thing - I worry that there may be some technical difficulties even though I, with my limited technical skillset, can't foresee any. (Waiting nervously for a dev to kick down my door and kill me :) )
I'm inclined to accept this since it handles the common case better than what we have right now, and the uncommon case of transparent images is going to be a nightmare no matter what.
From what I can tell the wallpaper itself doesn't respect this so we still end up loading the blurry image on the wallpaper, no?