When kwalletd4 was replaced by kwalletd5 I quickly got annoyed by the so much and unnecessarily larger password dialog. This patch addresses that issues, maing the dialog comparably compact as it was under KDE4.
BUG: 381231
Details
Details
- Reviewers
kfunk ngraham - Group Reviewers
Frameworks - Commits
- R236:9afc2c3768e0: more compact password dialog
I've been using this patch since before summer, on Mac and Linux. I never encountered a password dialog that became unusable or looked wrong.
Screenshots attached to the bug report I filed about this (https://bugs.kde.org/show_bug.cgi?id=381231):
Before:
After (packed):
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Screenshots attached to the bug report I filed about this (https://bugs.kde.org/show_bug.cgi?id=381231):
Before:
After (packed):
Comment Actions
Fantastic. Can you add the following onto its own line in the Summary section?
"BUG: 381231"
That will cause that bug to get automatically closed once this is merged.
| src/kpassworddialog.ui | ||
|---|---|---|
| 137 | Is this change intended? | |
Comment Actions
Is this change intended?
I doubt that (it's been a while). Probably something Designer added, and I can't imagine it would have an impact on packing. I'll check.
Comment Actions
Yeah, could you remove that and any other uynnecessary lines, so we have the bare minimum set of changes necessary to improve this?
Comment Actions
Couple more changes, if you please:
- Add the before-and-after screenshots to the Test Plan section so everyone who comes here sees them
- Add "BUG: 381231" on its own line in the Summary section, which will make that bug get automatically closed once this is landed.