The changes break down to a few different types:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Oh wow, there's a lot of stuff going on here. Let's try to dissect this a bit:
- Add app icons by getting flatpak-builder to rename and export them correctly.
So they weren't being found so far?
How can we detect this? I'm not very fond of having a rename on every single recipe.
- Remove wayland support, the current recommendation is for Qt/KDE apps to use XWayland under Flatpak for now
Whose recommendation is this? I'm pretty sure I'm running the applications on Wayland properly here. Also @graesslin put some work to make sure that was doable. Maybe his changes haven't landed in our images yet?
- Add graphics acceleration permissions
- Add sound permissions
- Build the GNU Go engine with kigo so it actually works
This sounds great (pun intended :P).
Yeah, sorry, I intended to do just a little bit, but got excited.
- Add app icons by getting flatpak-builder to rename and export them correctly.
So they weren't being found so far?
How can we detect this? I'm not very fond of having a rename on every single recipe.
Flatpak will only export icons if they have the App ID, same as desktop files and appstream metadata. so anything that isn't org.kde.krita (say) won't get exported and you'll see a broken icon on your desktop. Other than having a rename in every single recipe, you'd have to change every single icon name.
- Remove wayland support, the current recommendation is for Qt/KDE apps to use XWayland under Flatpak for now
Whose recommendation is this? I'm pretty sure I'm running the applications on Wayland properly here. Also @graesslin put some work to make sure that was doable. Maybe his changes haven't landed in our images yet?
I was basing this on the QT Portal talk at GUADEC however I see on flathub that this is now not true, awesome! I'll update the diff to revert that.
- Add graphics acceleration permissions
- Add sound permissions
- Build the GNU Go engine with kigo so it actually works
This sounds great (pun intended :P).
;-)