You don't have to worry about Phabricator going away, we were on Reviewboard for quite a long time before we started to move away from it.

Unfortunately, this two year old patch does not apply for me anymore to the current git master (while it did apply to v5.15.0, it would not compile then).

In addition, I'm not convinced this should be changed at the Frameworks level. Developers might rely on the current behaviour, so the patch should probably rather clarify the API docs from cp to cp -a. According to @dfaure, this is on purpose. If your IRC logs say otherwise, feel free to post them here for reference.

To give a practical example: Let's assume in Dolphin a user copies a folder to another location on the same partition, which he later plans to restore after trying out some things in the original folder. He would rightly expect to get back the original state, including all symlinks. With your patch (please correct me if I misunderstood) this would break.

Therefore, I would encourage you (in addition to the API docs modification) to provide patches, or at least open bugzilla issues where still missing, against applications where a deep copy would be the appropriate behaviour indeed (e.g. Gwenview).

@shlomif any plans on redoing this another way? Otherwise can you close the review request, to clean up dashboards?