Differential D8122

Adapt diff plugin to the new renderer plugin interface
ClosedPublic
Actions

Authored by vkrause on Oct 3 2017, 10:00 AM.

Details

Reviewers
knauss
Commits
R81:b00588ed5f55: Adapt diff plugin to the new renderer plugin interface
Summary

Unlike previously, this now also handles diffs that have text/plain as mimetype, and by using the standard attachment container you can also easily save the attachment.

Diff Detail

Repository
R81 KDE PIM Addons
Branch
diff-plugin
Lint
No Linters Available
Unit
No Unit Test Coverage
vkrause created this revision.Oct 3 2017, 10:00 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 3 2017, 10:00 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added a comment.Oct 3 2017, 1:12 PM

looks promissing :)

vkrause updated this revision to Diff 20292.Oct 3 2017, 1:16 PM

Use Grantlee-based attachment container.

vkrause updated this revision to Diff 20309.Oct 3 2017, 4:48 PM

Adapt to Grantlee template changes.

vkrause updated this revision to Diff 20420.Oct 7 2017, 8:44 AM

complete port to the new renderer API

vkrause updated this revision to Diff 20425.Oct 7 2017, 10:15 AM

cleanup debugging leftovers

vkrause retitled this revision from WIP Adapt diff plugin to the new renderer plugin interface to Adapt diff plugin to the new renderer plugin interface.Oct 7 2017, 10:16 AM
vkrause edited the summary of this revision. (Show Details)
knauss added inline comments.Oct 10 2017, 10:21 PM
plugins/messageviewer/bodypartformatter/autotests/diffdata/diff-akonadiconsole-16.12-master-ref.diff
1

whhy all this style is not needed anymore?

vkrause added inline comments.Oct 13 2017, 8:58 AM
plugins/messageviewer/bodypartformatter/autotests/diffdata/diff-akonadiconsole-16.12-master-ref.diff
1

The surrounding box is now provided by the generic attachment container template.

knauss accepted this revision.Oct 13 2017, 4:42 PM
This revision is now accepted and ready to land.Oct 13 2017, 4:42 PM
Closed by commit R81:b00588ed5f55: Adapt diff plugin to the new renderer plugin interface (authored by vkrause). · Explain WhyOct 14 2017, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20425

View Options

plugins/messageviewer/bodypartformatter/autotests/diffdata/diff-akonadiconsole-16.12-master-ref.diff

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/diffdata/kcontact1-ref.diff

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/diffdata/test1-ref.diff

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/diffhighlightertest.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/xdiff/CMakeLists.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/xdiff/diffhighlighter.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/xdiff/text_xdiff.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/xdiff/text_xdiff.json

Loading...