Add renderer plugin loader
ClosedPublic
Actions

Authored by vkrause on Oct 2 2017, 3:23 PM.

Details

Reviewers

Commits

R94:203890d80e78: Add renderer plugin loader

Summary

With this it's now possible to implement the diff highlighter using the
new API. However, it's far from convenient still as we can't easily
re-use Grantlee template fragments for the attachment containers yet.

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Oct 2 2017, 3:23 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 2 2017, 3:23 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

looks good but i would like to see the plugin using it.

vkrause mentioned this in D8122: Adapt diff plugin to the new renderer plugin interface.Oct 3 2017, 10:00 AM

D8122 shows the usage.

knauss accepted this revision.Oct 3 2017, 1:12 PM

This revision is now accepted and ready to land.Oct 3 2017, 1:12 PM

Closed by commit R94:203890d80e78: Add renderer plugin loader (authored by vkrause). · Explain WhyOct 3 2017, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		messageviewer/src/CMakeLists.txt (13 lines)
M		messageviewer/src/messagepartthemes/default/defaultrenderer.cpp (11 lines)
M		messageviewer/src/messagepartthemes/default/htmlblock.h (6 lines)
M		messageviewer/src/messagepartthemes/default/messagepartrendererbase.h (4 lines)
M		messageviewer/src/messagepartthemes/default/messagepartrendererfactory.cpp (34 lines)
A	M	messageviewer/src/messagepartthemes/default/messagepartrenderplugin.h (45 lines)
A	M	messageviewer/src/messagepartthemes/default/messagepartrenderplugin.cpp (24 lines)