This further simplifies attachment container Grantlee template usage.
Details
Details
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Also to do this with the root block would add a lot of global logic into the grantlee themes. Maybe we find a better solution for this.
| messageviewer/src/messagepartthemes/default/templates/asiconpart.html | ||
|---|---|---|
| 5 | not really happy with this change, becuase it makes it harder to read. and mire error prune to forget a clossing "</div>". | |
| messageviewer/src/messagepartthemes/default/templates/asiconpart.html | ||
|---|---|---|
| 5 | Well, this change moves the burden of adding the attachment blocks into the Grantlee templates and out of the individual plugins. This is what makes the current code of D8122 work without requiring any handling of isAttachment(). I think that is a step in the right direction. It might indeed be something we can add centrally in DefaultRenderer, and possibly even make non-conditional (having this for non-attachments doesn't really hurt after all), but that's a further improvement IMHO. | |
| messageviewer/src/messagepartthemes/default/templates/asiconpart.html | ||
|---|---|---|
| 5 |
yepp you are right +1 | |