cmake: Stop warning if dot is not found when CMake is run.
AbandonedPublic

Authored by rakuco on Sep 29 2017, 8:53 PM.

Details

Summary

dot is a runtime dependency (as the warning message already says), so there
is no point in looking for it at build-time. Distributions normally separate
build-time and run-time dependencies, and the latter do not need to be
installed when KGraphView is built.

Diff Detail

Repository
R491 KGraphViewer
Branch
dot-is-a-runtime-dependency
Lint
No Linters Available
Unit
No Unit Test Coverage
rakuco created this revision.Sep 29 2017, 8:53 PM

FindGraphviz.cmake uses DOT as well for finding the version of GraphViz that is installed -- not that the current module or code supports checking hthat version, but it's there.

FindGraphviz.cmake uses DOT as well for finding the version of GraphViz that is installed -- not that the current module or code supports checking hthat version, but it's there.

Sorry, I should've mentioned that I have another branch here with a rewritten FindGraphviz.cmake that uses graphviz_version.h instead of dot for version checking. This review request is just testing the waters :-)

I added kleag, the former author of kgraphviewer. Though he might still miss notifications from phabricator as before. Best contact him per email directly (find email on identity,kde,org)

In any case, instead of that manual warning, dot should be reported as dependency of TYPE RUNTIME, so it is listed in the cmake feature_summary. IIRC that needs a separate FindDot.cmake file, so there can be some

find_package(Dot QUIET)
set_package_properties(heaptrack_gui PROPERTIES
    DESCRIPTION "Tool which generates foo bar"
    URL "http://www.graphviz.org/"
    PURPOSE "Needed for foo bar"
    TYPE RUNTIME
)

Given you mentioned some further work on the cmake find files, that could go together as one.

@rakuco ping? Had you pursued your work here (incl. the rewritten FindGraphviz.cmake) or can we discard this review request as discontinued, to clean up our phab todo list?

rakuco abandoned this revision.Jul 15 2018, 9:46 PM

I've finally posted a more comprehensive patch in D14146 -- so much time passed that I lost my original branch and did something similar in spirit :-)