Add appdata for Filelight
ClosedPublic

Authored by lueck on Sep 25 2017, 6:11 PM.

Details

Summary

Infos taken from code, docbook and userbase

Test Plan

builds

Diff Detail

Repository
R352 Filelight
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Sep 25 2017, 6:11 PM
lueck updated this revision to Diff 19913.Sep 25 2017, 6:17 PM

fix typo and copy+paste nonsens

elvisangelaccio added inline comments.
misc/org.kde.filelight.appdata.xml
27
mak added inline comments.Sep 25 2017, 10:35 PM
misc/org.kde.filelight.appdata.xml
4

Just a minor thing: Since this is a new metainfo file, you might want to give the project the component-id org.kde.filelight and add a <launchable/> tag as described here https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable and in the quickstart guide: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps

In this case, the tag would be <launchable type="desktop-id">org.kde.filelight.desktop</launchable>
This would be very "modern" AppStream (the feature is about 6months old) - the file you already have is valid too, of course.

lueck updated this revision to Diff 19923.Sep 26 2017, 3:52 AM

add launchable tag
use websites/product-screenshots.git/ for screenshot
thx for review

lueck marked 2 inline comments as done.Sep 26 2017, 3:52 AM
mak accepted this revision.Oct 9 2017, 6:42 PM
This revision is now accepted and ready to land.Oct 9 2017, 6:42 PM
This revision was automatically updated to reflect the committed changes.