Split the Action menu
ClosedPublic

Authored by elvisangelaccio on Jan 11 2016, 5:52 PM.

Details

Reviewers
rthomsen
colomar
Summary

Currently the Action menu in Ark contains actions regarding the entries in the archive.
However, the Add File, Add Folder and Delete ones are actions that actually
edit the archive. So they would better fit under an Edit menu.
The Edit menu will also contain, hopefully, future actions like Cut, Copy and
Rename.

I don't like the Action name for the other menu, but I can't think of a better
alternative either. Suggestions?

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
elvisangelaccio retitled this revision from to Split the Action menu.
elvisangelaccio added reviewers: rthomsen, colomar.
elvisangelaccio updated this object.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 11 2016, 5:52 PM
colomar edited edge metadata.Jan 11 2016, 6:10 PM

Why should the items you put in the Edit menu not go into the Archive menu? As you said, they do apply to the archive.
And I'd rename "Action" to "File", but keep "Archive" as the first top-level item. Then we'd have a clear split between "Archive" with everything that affects the archive, and "File" for everything that affects files within the archive

In D790#15061, @colomar wrote:

Why should the items you put in the Edit menu not go into the Archive menu? As you said, they do apply to the archive.
And I'd rename "Action" to "File", but keep "Archive" as the first top-level item.

Yeah I was tempted to do so, but what stopped me is that File is usually the top-level item in the menubar. But if you think it's ok, I'll do it :)

Then we'd have a clear split between "Archive" with everything that affects the archive, and "File" for everything that affects files within the archive

What about the Extract action? It actually affects both the categories, since you can extract the whole archive *or* only a subset of the files. Due to the latter, do we keep it in the File menu?

Why should the items you put in the Edit menu not go into the Archive menu? As you said, they do apply to the archive.
And I'd rename "Action" to "File", but keep "Archive" as the first top-level item.

Yeah I was tempted to do so, but what stopped me is that File is usually the top-level item in the menubar. But if you think it's ok, I'll do it :)

Consistency with the task beats consistency across applications. Yes, this will make people stop and think for a moment, but it should become clear rather quickly which is which.

Then we'd have a clear split between "Archive" with everything that affects the archive, and "File" for everything that affects files within the archive

What about the Extract action? It actually affects both the categories, since you can extract the whole archive *or* only a subset of the files. Due to the latter, do we keep it in the File menu?

Actually, I think it would make sense have two "Extract" items, one in Archive which always extracts the whole archive, even if files where selected, and one in File, which only acts on selected files. The whole File menu should be deactivated if no files are selected.

In D790#15071, @colomar wrote:

Actually, I think it would make sense have two "Extract" items, one in Archive which always extracts the whole archive, even if files where selected, and one in File, which only acts on selected files. The whole File menu should be deactivated if no files are selected.

All right. I'll do this in a separate patch if you don't mind.

elvisangelaccio edited edge metadata.
  • Revert "Split the Action menu"
  • Merge branch 'rename-file-menu' into refactor/menubar
  • Restructure the Archive and File menus
In D790#15071, @colomar wrote:

Actually, I think it would make sense have two "Extract" items, one in Archive which always extracts the whole archive, even if files where selected, and one in File, which only acts on selected files. The whole File menu should be deactivated if no files are selected.

All right. I'll do this in a separate patch if you don't mind.

Sure!

Just one final thing to change: The "Open File" and "Open File With..." entries can drop the word "File" since they're in the "File" menu.

Drop "File" from the text of the Open actions.

Bump versions of .rc files

rthomsen edited edge metadata.Jan 14 2016, 6:53 PM

What about calling this menu "Entry"? Entries can be both files and folders...

What about calling this menu "Entry"? Entries can be both files and folders...

The question is: Can the actions in the "File" menu be applied to folders anyway?

In D790#15735, @colomar wrote:

What about calling this menu "Entry"? Entries can be both files and folders...

The question is: Can the actions in the "File" menu be applied to folders anyway?

Only the "Extract" one.

Ping?
I think we can go with the "File" name for the menu, since:

  • 3 actions out of 4 can only be applied to files, and not to directories.
  • The Extract action can be applied to both, but we're introducing this action only for clarity (see D795). Imho this is not enough to name the menu "Entry" instead of "File".
rthomsen accepted this revision.Feb 9 2016, 8:54 AM
rthomsen edited edge metadata.

Calling it "File" is fine with me.

This revision is now accepted and ready to land.Feb 9 2016, 8:54 AM