Introduce new Extract actions
ClosedPublic

Authored by elvisangelaccio on Jan 12 2016, 11:17 AM.

Details

Reviewers
rthomsen
colomar
Summary

If we introduce the new Archive and File menus, it makes sense to introduce different Extract actions as well.
The implementation is a little tricky, since I had to use a third Extract action for the toolbar. Basically we have:

  1. The Extract action in the Archive menu, which always extract the whole archive (even if the user selected some file).
  2. The Extract action in the File menu, which is only enabled if some file has been selected, and extracts only those files.
  3. The Extract action in the toolbar, which is the very same Extract action that Ark currently provides: it allows to extract the whole archive, or only the selected files (if any).

The action on the toolbar also gets the current CTRL+E shortcut, in order to not change the current behavior. The new actions don't have a shortcut yet, I couldn't find reasonable ones. Suggestions are welcome :)

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
elvisangelaccio retitled this revision from to Introduce new Extract actions.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added reviewers: rthomsen, colomar.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 12 2016, 11:17 AM
colomar edited edge metadata.Jan 12 2016, 5:58 PM

Makes sense like that!
I don't think Extract Archive and Extract File need separate shortcuts. They were mostly introduced for clarity, the standard Extract from the toolbar are likely what most users use most of the time anyway.

D790 has landed, so... ping on this one :)

I'm going to push this one, since the feature freeze is in less than one month and this patch is just an appendix of D788 anyway.

rthomsen accepted this revision.Feb 24 2016, 6:31 PM
rthomsen edited edge metadata.

Go ahead :)

This revision is now accepted and ready to land.Feb 24 2016, 6:31 PM

Go ahead :)

Thanks :)