The resource uses now an update interval for updating its content automatically. The default is 5 minutes.
Details
Details
I've tested it already in my development VM.
Its implemented like in the DAV resource.
Diff Detail
Diff Detail
- Repository
- R44 KDE PIM Runtime
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I assume the license changes should not be there? That would make the license inconsistent with the rest of the resource code.
| resources/tomboynotes/configdialog.ui | ||
|---|---|---|
| 89 | Use QSpinBox rather than KLineEdit, you can do it like [QLabel "Update interval:"] [QSpinBox] [QLabel "minutes"] | |
| resources/tomboynotes/tomboycollectionsdownloadjob.h | ||
| 6 | Unrelated change? | |
| resources/tomboynotes/tomboynotesresource.cpp | ||
| 81 | Wrong indentation | |
| resources/tomboynotes/tomboycollectionsdownloadjob.h | ||
|---|---|---|
| 6 | I would like to change the license. Should I create an other revision for this or should I only change all files regarding the license? | |
Comment Actions
You can change the license if you want to, but you must do it in a single commit that changes the license of the overall program in one go - you can't just have half of your program under one license and the other half under another. You also must contact anyone else who may have contributed if they are OK with the change (no need to contact people who just did a coding style and similar minor adjustments), and, finally, make sure you adhere to the KDE Licensing Policy
Comment Actions
Ok I've changed all to GLPv3.
I'm the main developer but I've used some code of other resources, AFAIK only of maildir and and mainly of DAV.
So possible copyright holders should be Sandro Knauß, Volker Krause and Till Adam. Laurent Montel did also some changes. It would be very nice if they could comment on this.
But in general AFAIK it shouldn't be a problem to change the license from "GPLv2 and later" to "GLPv3 and later". And all used is AFAIK "GPLv2 and later".
Comment Actions
Sorry, I missed your question beofre: you should definitely do this in a separate commit. Also you should add COPYING.GPL3 file to the root of kdepim-runtime with full text of the license, since your resource is the first one with this license.
Comment Actions
Ok then I'll do this separately. Can you commit the code changes? I have no right to commit.
Comment Actions
Please not that fast. Yes switching from GPL2+ to GPL3+ is an allowed move in license terms. But relicencing is more difficult than that, because if you change your resource from GPL2+ -> GPL3+ the complete kdepim-resource get GPL3+ indirectly, because you throw out the GPL2 option and for the repository the overall set of allowed licenses will be reduced to GPL3+ for kdepim-resources. So before doing that, you first have to check if there is any file in kdepim-resources that are GPL2 only. And than as next step you need to make sure that all parts, that are using the resources are not GPL2 only. Unfortunatelly, we had in past some situation, where we produces non releasable licenses situations in kdepim.
@lbeltrame : you have good overview about the licening situation in kdepim: is it a problem to switch from GPL2+ to GPL3+ for one resource.
Comment Actions
@knauss Good point. I think it's not worth relicensing to GPL v3, not because it's a bad license, but due to the massive amount of historical code in KDE PIM. So, to prevent further headaches for distributions, -1 to the license change.