Differential D7859

KMessageBox: Use question mark icon for question dialogs
ClosedPublic
Actions

Authored by rkflx on Sep 17 2017, 10:08 AM.

Details

Reviewers
cfeck
Group Reviewers
Frameworks
Commits
R236:9b05a12a43db: KMessageBox: Use question mark icon for question dialogs
Summary

Besides Information, Warning and Critical, the QMessageBox::Icon
enum supports icons of type Question. Instead of falling back to an
"information" icon, use a "question mark" icon for every
KMessageBox::question*().

Note: Using the Oxygen icon set still displays an "information" icon
(may need investigation).

Test Plan
  • kmessageboxtest now shows question mark icon for some dialogs
  • cursory look at lxr suggest most usage is a proper question indeed
  • question mark icon supported in Breeze and Adwaita icon set

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Sep 17 2017, 10:08 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 17 2017, 10:08 AM
cfeck accepted this revision.Sep 17 2017, 11:02 AM
This revision is now accepted and ready to land.Sep 17 2017, 11:02 AM
Closed by commit R236:9b05a12a43db: KMessageBox: Use question mark icon for question dialogs (authored by rkflx). · Explain WhySep 17 2017, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagebox.cpp (7 lines)

Diff 19607

View Options

src/kmessagebox.cpp

Loading...