Add zoom buttons to documentation view and make it able to zoom documentation using Ctrl + mouse wheel
AbandonedPublic
Actions

Authored by Sergobot on Jan 10 2016, 1:09 AM.

Details

Reviewers

mwolff
kfunk

Summary

Implements BUG: 285162

Test Plan

Tests passed, works as expected.

Diff Detail

Repository

R33 KDevPlatform

Lint

Lint Skipped

Unit

Unit Tests Skipped

Sergobot updated this revision to Diff 1832.Jan 10 2016, 1:09 AM

Sergobot retitled this revision from to Add zoom buttons to documentation view and make it able to zoom documentation using Ctrl + mouse wheel.

Sergobot updated this object.

Sergobot edited the test plan for this revision. (Show Details)

Sergobot added a reviewer: kfunk.

Sergobot set the repository for this revision to R33 KDevPlatform.

Sergobot added a project: KDevelop.

Sergobot changed the visibility from "Public (No Login Required)" to "KDevelop (Project)".

Sergobot changed the edit policy from "All Users" to "KDevelop (Project)".

Sergobot added a subscriber: kdevelop-devel.

Looks good to me in general.

The only issue I see with this is that we'll add zoom-related buttons to the documentation view toolbar (which is already crowded), for all documentation engines.

Better ideas welcome. My input:

Maybe move the actions to the StandardDocumentationView, and show them as overlay on the QWebView
Base StandardDocumentationView on plain QWidget, add a toolbar + QWebView as children
- imposes an API break wrt StandardDocumentationView

Anyone?

@Sergobot: Thanks for the patch! Will mark your GCI task as approved.

Note, there's another review implementing the same feature, arguably in a lot more complex way: https://git.reviewboard.kde.org/r/126685/

I would like to see what the UI looks like after adding all these actions.

kfunk edited edge metadata.Jan 11 2016, 6:02 PM

kfunk changed the visibility from "KDevelop (Project)" to "Public (No Login Required)".

Needs work

This revision now requires changes to proceed.Feb 2 2016, 10:21 PM

Ping, any progress on this?

As I suggested on the other RR (https://git.reviewboard.kde.org/r/126685/), please provide a shortcut to go back to the standard zoom level if you're using mouse-wheel zooming.

igorkushnir mentioned this in D3040: Allow scaling documentation view (BUG 285162).Oct 12 2016, 6:59 PM

I don't like adding more buttons, see also https://phabricator.kde.org/D3040 which seems to supersede this change set?

Sergobot abandoned this revision.Jan 24 2019, 1:23 PM

Revision Contents
Changeset List

			Path	Packages
M			documentation/documentationview.h (4 lines)
M			documentation/documentationview.cpp (17 lines)
M			documentation/standarddocumentationview.h (15 lines)
M			documentation/standarddocumentationview.cpp (54 lines)