[Plasma Components 3] Fix RTL in some widgets.
ClosedPublic
Actions

Authored by safaalfulaij on Sep 6 2017, 9:39 PM.

Details

Reviewers

Group Reviewers

Plasma
Frameworks

Commits

R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some widgets.

Summary

Some widgets are missed up in RTL mode, this should fix it.

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

safaalfulaij created this revision.Sep 6 2017, 9:39 PM

Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptSep 6 2017, 9:39 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

One widget I didn't know how to fix is the TabBar (The blue line that flows from left to right for the first item.)
Other widgets are behaving the same as QQC2 ones, like BusyIndicator and Dial, so I didn't change them. Not sure if they should be flipped or not.

davidedmundson added a subscriber: davidedmundson.Sep 6 2017, 9:52 PM

davidedmundson added inline comments.

src/declarativeimports/plasmacomponents3/ProgressBar.qml
33	I don't understand what this is doing?

broulik added a subscriber: broulik.Sep 6 2017, 9:59 PM

broulik added inline comments.

src/declarativeimports/plasmacomponents3/ProgressBar.qml
33	That's pretty clever, actually, A negative scale causes the item to be mirrored when rendered. However, not sure we can just blatantly mirror that graphic

safaalfulaij added inline comments.Sep 6 2017, 10:03 PM

src/declarativeimports/plasmacomponents3/ProgressBar.qml
33	Actually, it’s used in default QQC2 styling and I just stole it from there.. http://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/src/imports/controls/Slider.qml#n78

mart accepted this revision.Sep 9 2017, 12:37 PM

mart added a subscriber: mart.

mart added inline comments.

src/declarativeimports/plasmacomponents3/ProgressBar.qml
33	I think it's fine

This revision is now accepted and ready to land.Sep 9 2017, 12:37 PM

safaalfulaij retitled this revision from [WIP] Fix RTL in some plasmacomponents3 widgets. to [Plasma Components 3] Fix RTL in some widgets..Sep 9 2017, 9:10 PM

It seems that the TabBar's problem is an upstream issue with ListView and highlighting animation.
Will report about it soon.

Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some widgets. (authored by safaalfulaij). · Explain WhySep 10 2017, 7:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmacomponents3/ComboBox.qml (4 lines)
M			src/declarativeimports/plasmacomponents3/ProgressBar.qml (3 lines)
M			src/declarativeimports/plasmacomponents3/RangeSlider.qml (1 line)
M			src/declarativeimports/plasmacomponents3/Slider.qml (3 lines)