Imho, it should just use the one set in system settings. Not hardcode anything besides perhaps a default one if nothing has been set.

In D7655#143234, @markg wrote:

Imho, it should just use the one set in system settings. Not hardcode anything besides perhaps a default one if nothing has been set.

This would be very hard to implement, unfortunately. What if the custom shortcut is not a "Modifier+Key" type of shortcut?
We can leave it as TODO for the future, but in the meantime I'd just fix the regression.

Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned {Shift, Del} to something different?

Maybe:

1. If shortcuts of move_to_trash (A) is a proper subset of the shortcuts of delete (B) -> use the keys of B\A to select the actual behavior of the remove action (in the default configuration B\A is equal to {Shift})
2. Else show both the move_to_trashand the delete action instead of the remove action

But I think this is too complicated and error-prone ...

Would it be possible to add constraints to the shortcut settings dialog? Maybe that delete is always a user selectable modifier key + shortcuts of move to trash?

In D7655#143845, @elvisangelaccio wrote:

In D7655#143604, @emmanuelp wrote:

Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned {Shift, Del} to something different?

Maybe:

1. If shortcuts of move_to_trash (A) is a proper subset of the shortcuts of delete (B) -> use the keys of B\A to select the actual behavior of the remove action (in the default configuration B\A is equal to {Shift})
2. Else show both the move_to_trashand the delete action instead of the remove action
   
   But I think this is too complicated and error-prone ...
   
   Would it be possible to add constraints to the shortcut settings dialog? Maybe that delete is always a user selectable modifier key + shortcuts of move to trash?

This could be done in KShortcutsEditor, yes. It would be a good solution, I'll give it a shot...

Meh, that's a very complex codebase. I don't really feel like touching it for something that would be useful only for Dolphin.

So here's what we can do:

1. Revert to the old behavior of hardcoding Shift+Del and Del, ignoring the user-defined shortucts.
2. Drop DolphinRemoveAction and just show both actions in the context menu.
3. This patch.

I'd avoid 2) because we would lose a nice feature and increase clutter in the context menu.