Differential D7582

[FrameSvgItem] Create margins/fixedMargins object on demand
ClosedPublic
Actions

Authored by broulik on Aug 28 2017, 10:42 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins object on demand
Summary

On my machine I end up creating 490 margins and 490 fixed margin objects.
After this change I only create 171 margin objects and 20 fixed margin objects.

Test Plan

RAM consumption negligible and 0.1ms time saved but especially given fixed margins is hardly used, imho shouldn't create a ton of objects that are unused.

Changing themes seems fine.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 28 2017, 10:42 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptAug 28 2017, 10:42 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 29 2017, 8:54 AM
This revision is now accepted and ready to land.Aug 29 2017, 8:54 AM
Closed by commit R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins object on demand (authored by broulik). · Explain WhyAug 29 2017, 9:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18877

View Options

src/declarativeimports/core/framesvgitem.h

Loading...
View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...