[FrameSvgItem] Create margins/fixedMargins object on demand
ClosedPublic

Authored by broulik on Aug 28 2017, 10:42 AM.

Details

Summary

On my machine I end up creating 490 margins and 490 fixed margin objects.
After this change I only create 171 margin objects and 20 fixed margin objects.

Test Plan

RAM consumption negligible and 0.1ms time saved but especially given fixed margins is hardly used, imho shouldn't create a ton of objects that are unused.

Changing themes seems fine.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 28 2017, 10:42 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptAug 28 2017, 10:42 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 29 2017, 8:54 AM
This revision is now accepted and ready to land.Aug 29 2017, 8:54 AM
This revision was automatically updated to reflect the committed changes.