Since I started using Qt5.9.1, the icons on the Kontact iconssidepane have been displayed too close together (see the pre-fix.png attachment)
This patch spaces the icons a little farther apart (see post-fix.png attachment)
Since I started using Qt5.9.1, the icons on the Kontact iconssidepane have been displayed too close together (see the pre-fix.png attachment)
This patch spaces the icons a little farther apart (see post-fix.png attachment)
I didn't try Qt5.8, but I know this problem wasn't in Qt5.7 as I used that version for a long time without seeing the text cutoff.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I put the pre-fix at https://imagebin.ca/v/3Y1iRhORRnlk and the post-fix at https://imagebin.ca/v/3Y1ikQqPa9ee
The post-fix looks weird - the icons are weirdly stretched out vertically.
I think the problem here is that when you change the icon size, the view does not re-query the sizeHint() and instead uses the old cached one for smaller icons. Just calling QAbstractItemView::reset() when you change the icon size should be good enough?
you're right. I hadn't noticed the stretching.
No the reset() didn't help that I recall. the text is cutoff on initial start of Kontact.
I'll need to look again.
no longer see vertical stretching of the icons, but the spacing is nice now.
I put the new post-fix image at https://imagebin.ca/v/3cDE4o4vH19k
I find it strange that nobody else is complaining. Isn't anyone else using Qt5.9.x?
before I commit this...
since you approve, does that mean other folks are now encountering this problem? and I'm not delusional?
I started noticing the icons being weird recently and remember your patch. Since I updated to Qt 5.9 since you first uploaded the patch (and I couldn't reproduce the problem there), I tried to apply the patch, restarted Kontact and haven't seen issues with the icons since, so I assume it fixed it. I did not go digging into Qt to see if it is really affected by the patch...