| sitter | |
| dfaure |
| Frameworks |
We are currently checking if the klauncher is running under different
user, and if so, we decide to fork the slave.
In addition to that also assert that klauncher is actually running or
not, if klauncher is not installed due to kinit being higher tier
framework then the kio or due to the usage of kio slave on !plasma
environments where kinit is very less likely to be installed.
This also helps packagers to avoid the circular dependency between kio
and kinit. For example,
Tested on openbox session where kdeinit5 was not functional
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Makes sense.
| src/core/slave.cpp | ||
|---|---|---|
| 111 | } else if (...) { We don't want/need to turn reply into a bool if it's not valid. Alternatively this could be written as if (!reply.isValid() || getuid() != reply) // not running, or owned by a different user but I don't mind either way. | |
Just remove "assert" from the commit message, this isn't asserting anything, it's handling an error case that the code wasn't handling (at least not correctly).
| src/core/slave.cpp | ||
|---|---|---|
| 111 | somehow arc diff is failing on me to update this change's summary and description.. I will commit this change and summary change . | |
You committed (... && getuid() != reply) rather than ||. We'll want a fork in either scenario, so this should be || as suggested by David.
Yeah realized that after commiting it, fixed in e72b70a064916310435fa19e0740f376bb687e4c