Dragging tabs in konsole lags
ClosedPublic

Authored by McPain on Aug 21 2017, 10:39 AM.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Aug 21 2017, 10:39 AM
McPain added a reviewer: hindenburg.
davidedmundson accepted this revision.Aug 21 2017, 11:30 AM
This revision is now accepted and ready to land.Aug 21 2017, 11:30 AM
hindenburg accepted this revision.Aug 26 2017, 11:27 PM

+1 looks fine thanks

Do you have commit access?

Do you have commit access?

No, I haven't

This revision was automatically updated to reflect the committed changes.

I've noticed that since this commit, I often accidentally drag-n-drop a tab outside the window such that it creates a new window.

dfaure added a subscriber: dfaure.May 30 2018, 3:59 PM

I've noticed that since this commit, I often accidentally drag-n-drop a tab outside the window such that it creates a new window.

Me too, and it's really annoying. If you click on a tab, and then move by 1 pixel (shaky hand), you start a drag.
startDragTime is 10ms here, that's really really short.
Can we kill the time check completely?
Most widgets only check startDragDistance().
I think removing the startDragTime() usage completely would fix both the initial issue (long delay required) and the new issue (accidental drag when moving by 1 pixel).

Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptMay 30 2018, 3:59 PM

Thanks for the reminder - I meant to look at this earlier