Differential D7439

Don't clear Qt's SSL CA certificate store
ClosedPublic
Actions

Authored by vkrause on Aug 20 2017, 6:20 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:5947eeb5f5aa: Don't clear Qt's SSL CA certificate store
Summary

This breaks all subsequent SSL connections using QSslSocket or QNAM.

Thiago said about this on #kde-devel: "in the old days, it used to be
because Qt shipped with a very old database, we haven't done that in
8 years".

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 20 2017, 6:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 20 2017, 6:20 PM
dfaure accepted this revision.Aug 21 2017, 2:12 PM
dfaure added a subscriber: dfaure.

Yep. We don't even have our own set of CA certificates, anymore, so clearing the Qt ones makes no sense anymore. Maybe this is why I was getting lots of SSL errors in konqueror-kf5...

This revision is now accepted and ready to land.Aug 21 2017, 2:12 PM
Closed by commit R241:5947eeb5f5aa: Don't clear Qt's SSL CA certificate store (authored by vkrause). · Explain WhyAug 21 2017, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18497

View Options

src/core/ksslcertificatemanager.cpp

Loading...