Adds RTF support to Okular
BUG: 339835
Details
Details
- Reviewers
- None
- Group Reviewers
Calligra: 3.0 Okular - Commits
- R8:4e15d65ff0ea: Add RTF support to Okular
Okular correctly renders RTF documents.
RTF is added to Okular's mime filter
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just a quick note (I can't test the rest of the patch):
| filters/words/rtf/import/okularApplication_rtf_calligra.desktop | ||
|---|---|---|
| 7 | Qt5 applications use -qwindowtitle, not -caption . I just fixed it for the other generators. | |
Comment Actions
Is there actually no code? I.e. is it just loading an exising plugin that knows how to use rtf but wasn't told about it?
Comment Actions
@aacid poked me as well to look at this., so I give in, as actually I might indeed be the one knowing most about this code still. Sadly out of loop with Calligra & Okular, not even build setups. But what I remember from the time when I hacked on the Okular plugins of Calligra, this patch looks pretty okay/complete when it comes to extending support for RTF.
So no official ship-it, given I am currently not active in the Calligra project, but still a "looks good (untested)."
If you have tested this well and feell confident, guess you just should push this to master, as it also does not change other things, on your own risk :)
You might though want to also update https://phabricator.kde.org/source/calligra/browse/master/README.PACKAGERS