Allow to only build the kauth-policy-gen code generator
ClosedPublic

Authored by vkrause on Aug 12 2017, 12:21 PM.

Details

Summary

This is primarily useful for cross-compilation, where e.g. with Yocto
neither Qt5Widgets nor PolicyKit are easily available for the host build.

Diff Detail

Repository
R283 KAuth
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 12 2017, 12:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 12 2017, 12:21 PM
apol added a subscriber: apol.Nov 12 2017, 12:43 AM
apol added inline comments.
src/ConfigureChecks.cmake
106

Is this change required?

153–157

if (PolkitQt5-1_FOUND)?

vkrause updated this revision to Diff 22225.Nov 12 2017, 12:17 PM

Integrate review feedback.

apol accepted this revision.Nov 12 2017, 6:29 PM
This revision is now accepted and ready to land.Nov 12 2017, 6:29 PM
This revision was automatically updated to reflect the committed changes.
kossebau added inline comments.
CMakeLists.txt
91

This installs KF5AuthTargets.cmake based on the condition, but KF5AuthConfig.cmake still includes the target file unconditionally, so cmake would fail over missing the file when using find_package(KF5Auth).

So are the cmake files not used in the case to support here at all, and all of the cmake config handling should be wrapped?

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptFeb 14 2022, 11:30 AM
vkrause added inline comments.Feb 14 2022, 4:50 PM
CMakeLists.txt
91

Right, the config files don't need to be installed in this case either. This was done for cross-compilation, nothing on the host system will use KAuth via a CMake config file. We do need the tools targets config file though, but that is separate.